Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table download to match the spec #384

Merged

Conversation

cristineguadelupe
Copy link
Contributor

Only today did I realize that I wasn't following the spec correctly.
I've fixed both sides and we can release simultaneously if you think it's worth it

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! You can bump the dependency on kino once released to ensure compatibility :)

@cristineguadelupe cristineguadelupe merged commit 905c9eb into livebook-dev:main Jan 22, 2024
1 check passed
@cristineguadelupe cristineguadelupe deleted the cg-fix-download branch January 22, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants