Check for mkcert in PATH if mkcertPath not given, before attempting a download #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of this plugin, a life saver, because certain browser features cannot be used without HTTPS. As someone developing for WebXR, essential for local testing.
Description
This PR makes
vite-plugin-mkcert
check formkcert
inPATH
, ifmkcertPath
is not defined, before attempting the default download.Additional context
This is to solve two things, which I encountered in an environment with a corporate firewall.
vite-plugin-mkcert
doesn't seem to work with with our proxy and fails the download withERCONNRESET
. Downloading manually and specifyingmkcertPath
works, but leads to a code portability problem if the downloadedmkcert
is not part of the vite-projects's repo and an OS portability issue, if you check in the windows'mkcert
, but another dev uses linux and vice-versa. Installingmkcert
toPATH
and relying onvite-plugin-mkcert
to checkPATH
was the cleanest solution for me.What is the purpose of this pull request?