Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Carrier 42P250HX #88

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ericpignet
Copy link

Adding full support for air conditioner: Carrier 42P250HX
Codes obtained through the Learn command of HomeAssistant with a Broadlink RM3 Pro.
Codes tested on my own device with SmartIR.

@litinoveweedle
Copy link
Owner

Hello, thank you for contribution.

  1. Please do not modify CLIMATE_CODES.md, it is autogenerated.Please revert this commit.
  2. Did you checked preset modes support for climate devices? It is now for testing in the beta release If your AC units support something like 'eco' or 'hi-power' modes those could be added.

@litinoveweedle
Copy link
Owner

Hello,
it seems that your PR is failing Lint job. There was recently update for changed-files workflow which might be fix. Could you please close this PR, pull & merge master into your repo branch and create new clean PR? In addition I think you are missing "temperatureUnit": "C", entry in you file (this would be checked and detected by Lint if not failing).

@ericpignet
Copy link
Author

Hi @litinoveweedle
There is no turbo or eco mode on this AC model. The only two extra functions there are are:

  • 'Ionizer' mode, which I have never turned off. All codes were recorded with it on. Maybe this one could be used as preset?
  • Air flow direction (flap). I recorded all codes with this set to auto. This corresponds to the swing_mode of the Climate integration. That would take me ages to record all codes for each swing mode, I might do it later but I would prefer to already get current code file, which I've been using with upstream SmartIR for a while, merged, if that's fine with you.

I'll add the missing temperature unit.

@ericpignet
Copy link
Author

I've also rebased from latest master which should fix the Lint issues without having to recreate a PR.

@litinoveweedle litinoveweedle merged commit 07080e2 into litinoveweedle:master Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants