Lights support #139
Merged
Lights support #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `delay` parameter from get_controller call - don't await async_write_ha_state - call async_write_ha_state when state is changed to off
Light: changes required to work in current HA
Even though the existing configs are all for Broadlink remote codes, users may want to know for future how to configure other remotes. Reformatted table. Reword section on device configs to avoid confusion with the configuration.yaml config.
Use the base class's _attr_supported_color_modes rather than tracking the support separately and overriding the property.
Lights: supported color mode cleanup and documentation improvement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return self._colortemp | ||
|
|
||
| @property | ||
| def min_color_temp_kelvin(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| return self._colortemps[0] | ||
|
|
||
| @property | ||
| def max_color_temp_kelvin(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add light support