Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove pytest-asyncio dependency and fix more resource warnings #3883

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

fix: Remove pytest-asyncio dependency and fix more resource warnings #3883

wants to merge 16 commits into from

Commits on Nov 29, 2024

  1. Treat warnings as errors unless explicitly ignored

    @gsakkis @provinzkraut
    gsakkis authored and provinzkraut committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a990423 View commit details
    Browse the repository at this point in the history

  2. Don't error for ResourceWarning coming from pytest-asyncio

    @gsakkis @provinzkraut
    gsakkis authored and provinzkraut committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    ab75076 View commit details
    Browse the repository at this point in the history

  3. Fix: clean up all unclosed UploadFiles

    @gsakkis @provinzkraut
    gsakkis authored and provinzkraut committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    9329f1d View commit details
    Browse the repository at this point in the history

  4. run_server fixture: wait for killed process

    @gsakkis @provinzkraut
    gsakkis authored and provinzkraut committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    4ea485b View commit details
    Browse the repository at this point in the history

  5. 1st pass, remove pytest-asyncio, remove trio backend

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    c132cc4 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into fix-resource-warnings

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3f8c8b9 View commit details
    Browse the repository at this point in the history

  7. fix test_concurrency socket unclosed

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    70f2250 View commit details
    Browse the repository at this point in the history

  8. commenting tests in concurrency that I think are messing up the suite… 

    … somehow
    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    4a9b1da View commit details
    Browse the repository at this point in the history

  9. messed up with uv

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    55dccb5 View commit details
    Browse the repository at this point in the history

  10. new lock

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    5cb0289 View commit details
    Browse the repository at this point in the history

  11. forgotten async test not marked

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    a97e262 View commit details
    Browse the repository at this point in the history

  12. 2 tests also async, dont seem to pass on trio

    @euri10
    euri10 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    8cf963a View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into fix-resource-warnings

    @cofin
    cofin authored Nov 29, 2024
    Configuration menu
    Copy the full SHA
    1e15a22 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. remove trio entirely, 2 tests fails in same spot each time except its… 

    … on a diff param alternative test_cors_simple_response and test_openapi_swagger, all the time its a unclosed socket on redis port 6397
    @euri10
    euri10 committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    3d3adf2 View commit details
    Browse the repository at this point in the history

  2. 1 failing test now I commented out those in test_concurrency which se… 

    …ems to have a delayed unclosed socket
    @euri10
    euri10 committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    3d8f97d View commit details
    Browse the repository at this point in the history

  3. same 2 tests fails with all test_concurrency commented, still redist … 

    …port
    @euri10
    euri10 committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    2de1d5c View commit details
    Browse the repository at this point in the history