Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Changing incorrect indentation in the code example "creating-middleware#inheriting-abstractmiddleware" #3857

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

RenameMe1
Copy link
Contributor

Description

Changes:

  • I'm change indentation of the await send(message) expression in send_wapper function which was causing the ERROR: ASGI callable returned without completing response.

link: https://docs.litestar.dev/2/usage/middleware/creating-middleware.html#inheriting-abstractmiddleware

Closes

Adjusting the indentation of the await send(message) line in Inheriting AbstractMiddleware
Adjusting the indentation of the await send(message) line in Inheriting AbstractMiddleware
@RenameMe1 RenameMe1 requested review from a team as code owners November 14, 2024 10:49
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: small type/docs pr/external Triage Required 🏥 This requires triage labels Nov 14, 2024
Copy link
Contributor

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@Alc-Alc
Copy link
Contributor

Alc-Alc commented Nov 14, 2024

@all-contributors add @RenameMe1 for docs

@Alc-Alc
Copy link
Contributor

Alc-Alc commented Nov 14, 2024

@all-contributors add @RenameMe1 for doc

I have no idea why its not getting triggered, if it doesn't I can add you the next time 🙂

Copy link
Contributor

@Alc-Alc

I've put up a pull request to add @RenameMe1! 🎉

@Alc-Alc Alc-Alc enabled auto-merge (squash) November 14, 2024 11:07
@Alc-Alc Alc-Alc merged commit 0fdbfa3 into litestar-org:main Nov 14, 2024
24 checks passed
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation pr/external pr/internal size: small Triage Required 🏥 This requires triage type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants