feat: OpenAPI plugins send CSRF request header #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: small
type/feat
pr/external
Triage Required 🏥
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3754 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 331 331
Lines 15277 15287 +10
Branches 2445 2447 +2
=======================================
+ Hits 15025 15035 +10
Misses 112 112
Partials 140 140 ☔ View full report in Codecov by Sentry. |
floxay
force-pushed
the
openapi-plugins-csrf
branch
from
9c4cd34 to
59c219f
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3754 |
|
@all-contributors add @floxay for code and tests |
|
I've put up a pull request to add @floxay! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported OpenAPI UI clients will extract the CSRF cookie value and attach it to the request headers if CSRF is enabled on the application.
Scalar (scalar/scalar#2810), Redoc and (Stoplight) Elements does not seem to support interceptors or some other mechanism to achieve this.
Currently it also sends the header on "safe" methods but for both currently supported UI clients (Swagger and RapiDoc) it's possible to limit this to "unsafe" methods only, if required.