Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenAPI): lazy import example creator #2390

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Sep 30, 2023

Only import function to create OpenAPI examples when needed; In the case where users have turned off generating examples this import is not needed at all.

This cuts the time it takes to import litestar in half by avoiding an expensive polyfactory import and is the first step in making polyfactory optional.

@provinzkraut provinzkraut requested review from a team as code owners September 30, 2023 10:11
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and very welcomed.

@cofin cofin enabled auto-merge (squash) September 30, 2023 17:08
@provinzkraut provinzkraut force-pushed the lazy-import-polyfactory branch from 814b7fd to 12c50d4 Compare September 30, 2023 17:19
@provinzkraut provinzkraut merged commit 2756f7e into main Sep 30, 2023
@provinzkraut provinzkraut deleted the lazy-import-polyfactory branch September 30, 2023 17:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants