Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Make litestar CLI part of the base package #2318

Closed
JacobCoffee opened this issue Sep 19, 2023 · 1 comment · Fixed by #2346
Closed

Enhancement: Make litestar CLI part of the base package #2318

JacobCoffee opened this issue Sep 19, 2023 · 1 comment · Fixed by #2346
Assignees
@lsanpablo @JacobCoffee
Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on

Comments

@JacobCoffee
Copy link
Member

JacobCoffee commented Sep 19, 2023 •
edited
Loading

Summary

Move the CLI dependencies into the core package

Basic Example

pip install litestar should include the Litestar CLI

pip install litestar[standard] should continue to do the same thing (base + uvicorn, etc.)

Drawbacks and Impact

  • Heavier package with click-rich (click + rich) installed

Unresolved questions

No response

Flask, Django, etc. do this; It makes sense for us. Relevant Discord forum post:
https://discord.com/channels/919193495116337154/1152738535397404752

Funding

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@JacobCoffee JacobCoffee added Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on labels Sep 19, 2023
@lsanpablo
Copy link
Contributor

I can look into this.

@lsanpablo lsanpablo mentioned this issue Sep 23, 2023
Merged
3 tasks
JacobCoffee added a commit that referenced this issue Sep 27, 2023
@lsanpablo @JacobCoffee
feat(#2318): install CLI by default (#2346)
ab84566 
Co-authored-by: Jacob Coffee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsanpablo lsanpablo

@JacobCoffee JacobCoffee

Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#2318): install CLI by default lsanpablo/litestar
2 participants
@lsanpablo @JacobCoffee