Hotfix of tee-test dependency in CI #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traf333
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
I was curious why didn't we skip the whole job and now it's clear. Thanks @Kailai-Wang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As topic, otherwise the tee-test will be launched too early:
I added some comments to further explain the usage in our case, because# [3] please beware that if a job inneedsis skipped, its dependent job will also be skipped,# see actions/runner#491No we can't use it in job level, because if the matrix is completely skipped, the status check will be pending forever, that was why I forced it to always run: