Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select chains to benchmark in the benchmarking CI #677

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Select chains to benchmark in the benchmarking CI #677

merged 3 commits into from
Jul 1, 2022

Conversation

ziming-zung
Copy link
Contributor

resolves #647

Kailai-Wang
Kailai-Wang reviewed Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good, just a few small things (see inline comments)

.github/workflows/benchmark-runtime-weights.yml Show resolved Hide resolved
.github/workflows/benchmark-runtime-weights.yml Show resolved Hide resolved
.github/workflows/benchmark-runtime-weights.yml Show resolved Hide resolved
@Kailai-Wang Kailai-Wang merged commit 2adfef5 into dev Jul 1, 2022
@Kailai-Wang Kailai-Wang deleted the 647-select-chains branch July 1, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Kailai-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select chains to benchmark in the benchmarking CI
2 participants
@ziming-zung @Kailai-Wang