Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify construct_runtime syntax #674

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Simplify construct_runtime syntax #674

merged 3 commits into from
Jun 30, 2022

Conversation

ziming-zung
Copy link
Contributor

resolves #634

Kailai-Wang
Kailai-Wang reviewed Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but some of my questions inline

runtime/litentry/src/lib.rs Outdated Show resolved Hide resolved
runtime/litmus/src/lib.rs Outdated Show resolved Hide resolved
runtime/litmus/src/lib.rs Outdated Show resolved Hide resolved
runtime/moonbase/src/lib.rs Outdated Show resolved Hide resolved
runtime/moonbase/src/lib.rs Outdated Show resolved Hide resolved
runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved
runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved
runtime/litmus/src/lib.rs Show resolved Hide resolved
runtime/litmus/src/lib.rs Outdated Show resolved Hide resolved
@ziming-zung
Copy link
Contributor Author

It is intentional. Because these pallet have GenesisConfig and we don't write in chain_spec configuration . If left out the types, there are some errors during compiling.

@codecov-commenter
Copy link

Codecov Report

Merging #674 (d2578df) into dev (42a4284) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #674   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          12       12           
  Lines        1666     1666           
=======================================
  Hits         1598     1598           
  Misses         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a4284...d2578df. Read the comment docs.

@Kailai-Wang Kailai-Wang merged commit ca9822a into dev Jun 30, 2022
@Kailai-Wang Kailai-Wang deleted the 634-simplify-construct branch June 30, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kailai-Wang Kailai-Wang Kailai-Wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify construct_runtime syntax
3 participants
@ziming-zung @codecov-commenter @Kailai-Wang