P 1277 Avoid depending on moonbeam/astar deps #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2025 13:25
copy rpc related code and put it into separate repo `litentry/moonbeam-vendor-rpc`
Kailai-Wang
approved these changes
Jan 24, 2025
parachain/scripts/clean-network.sh
Outdated
| # the network might not be started with zombienet | ||
| killall polkadot || true | ||
| killall litentry-collator || true | ||
| else | ||
| kill -2 $ZOMBIENET_PID | ||
| sudo kill -2 $ZOMBIENET_PID |
There was a problem hiding this comment.
I think we don't need sudo here
There was a problem hiding this comment.
wired. I was getting something like ./scripts/clean-network.sh: line 27: kill: (388645) - Operation not permitted.
But now it's disappeared.
I will remove this sudo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove moonbeam/astar direct dependency;
copy rpc related code and put it into repo
litentry/moonbeam-vendor-rpc.Also check repo: https://github.com/litentry/moonbeam-vendor-rpc