Use custom txpool to workaround the invalid tx #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silva-fj
approved these changes
Dec 18, 2024
nvm, I read the comments. They should be removed during revalidation |
|
Yes the tx is not lost tho, it's forked, so the client should still get valid response back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As topic.
A proper fix is using fork-aware txpool as done here: paritytech/polkadot-sdk#4639
However we are using
stable2407branch which means direct cherry-picking will result in many incompatible issues. I also tried ported versions from tanssi and it didn't work so well.The workaround is taken from the comment in paritytech/polkadot-sdk#1202 (from Frequency) - in my tests it looked good without
--delayed-best-block