-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: P-1221 supported new omni account api in client-sdk #3208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we release a new version of the client SDK on npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this, there are a couple of things that need to be adjusted
tee-worker/identity/client-sdk/packages/client-sdk/src/lib/requests/add-account.request.ts
Show resolved
Hide resolved
tee-worker/identity/client-sdk/packages/client-sdk/src/lib/requests/remove-accounts.request.ts
Outdated
Show resolved
Hide resolved
tee-worker/identity/client-sdk/packages/client-sdk/src/lib/type-creators/member-account.ts
Outdated
Show resolved
Hide resolved
8908cfc
to
9d74f06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
…t, remove_accounts, publicize_account
9d74f06
to
dd8606b
Compare
add_account, remove_accounts, publicize_account
Context
As title
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable