Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: P-1221 supported new omni account api in client-sdk #3208

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

higherordertech
Copy link
Contributor

add_account, remove_accounts, publicize_account

Context

As title

Labels

Please apply following PR-related labels when appropriate:

  • C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
  • C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

Copy link

linear bot commented Dec 17, 2024

@higherordertech higherordertech requested a review from a team December 17, 2024 07:16
Copy link
Contributor

@0xverin 0xverin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release a new version of the client SDK on npm?

Copy link
Contributor

@silva-fj silva-fj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this, there are a couple of things that need to be adjusted

Copy link
Contributor

@silva-fj silva-fj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@higherordertech higherordertech enabled auto-merge (squash) December 22, 2024 08:56
@higherordertech higherordertech merged commit bc3537e into dev Dec 22, 2024
22 checks passed
@higherordertech higherordertech deleted the omni-account-client-sdk branch December 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants