client-sdk: decode the result of native trusted operations #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Alvarez <[email protected]>
Signed-off-by: Jonathan Alvarez <[email protected]>
Signed-off-by: Jonathan Alvarez <[email protected]>
Signed-off-by: Jonathan Alvarez <[email protected]>
silva-fj
reviewed
Nov 7, 2024
| response: enclaveResult, | ||
| response, | ||
| extrinsicHash: extrinsic_hash.toString(), | ||
| blockHash: block_hash.toString(), |
There was a problem hiding this comment.
The block_hash is an Option, would this work?
There was a problem hiding this comment.
It won't throw, if that's what you mean.
It'd either be: the hex value, empty strings, or 0x0000...
but for these methods, blockHash should always be there, right? since we are watching until InBlock?
There was a problem hiding this comment.
Yes, we are waiting until the is Finalized
silva-fj
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as topic
client follow-up of #3155 now that the native responses include results.
Published packages