Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P 1114 error message from production worker #3159

Merged
merged 4 commits into from
Nov 5, 2024
Merged

P 1114 error message from production worker #3159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4800189
refactor: adjust log level for invalid connection hash
felixfaisal Nov 4, 2024
85d7127
refactor: change log level only for invalid connection hash
felixfaisal Nov 4, 2024
17bed5f
fix: build
felixfaisal Nov 5, 2024
eaeaada
Merge branch 'dev' into p-1114-error-message-from-production-worker
felixfaisal Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tee-worker/bitacross/core-primitives/top-pool/src/watcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extern crate alloc;
use crate::primitives::TxHash;
use alloc::{string::String, sync::Arc, vec::Vec};

use itc_direct_rpc_server::SendRpcResponse;
use itc_direct_rpc_server::{DirectRpcError, SendRpcResponse};
use itp_types::{BlockHash as SidechainBlockHash, TrustedOperationStatus};
use log::*;

Expand Down Expand Up @@ -124,7 +124,12 @@ where

fn send(&mut self, status: TrustedOperationStatus) {
if let Err(e) = self.rpc_response_sender.update_status_event(*self.hash(), status) {
error!("failed to send status update to rpc client: {:?}", e);
match e {
DirectRpcError::InvalidConnectionHash => {
warn!("Client connection interrupted while sending status update");
},
_ => error!("Failed to send status update to RPC client: {:?}", e),
}
}
}

Expand Down
9 changes: 7 additions & 2 deletions tee-worker/identity/core-primitives/top-pool/src/watcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extern crate alloc;
use crate::primitives::TxHash;
use alloc::{string::String, sync::Arc, vec::Vec};

use itc_direct_rpc_server::SendRpcResponse;
use itc_direct_rpc_server::{DirectRpcError, SendRpcResponse};
use itp_types::{BlockHash as SidechainBlockHash, TrustedOperationStatus};
use log::*;

Expand Down Expand Up @@ -124,7 +124,12 @@ where

fn send(&mut self, status: TrustedOperationStatus) {
if let Err(e) = self.rpc_response_sender.update_status_event(*self.hash(), status) {
error!("failed to send status update to rpc client: {:?}", e);
match e {
DirectRpcError::InvalidConnectionHash => {
warn!("Client connection interrupted while sending status update");
},
_ => error!("Failed to send status update to RPC client: {:?}", e),
}
}
}

Expand Down
Loading