-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AccountStore in-memory state initialization and synchronization #3133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got pretty much nothing to complain, thanks!
Have you tried it locally?
- I had some problem with nested ecall -> ocall, in some old issue though
- Does the paged retrieval work correctly?
I ran it locally but it's not fully tested as we currently don't have an easy way to generate enough data for testing |
I think a (so far) easy way is to use cli to batch request vcs (which will generate new IDGraphs if it's a new account), and then use Then you can see if it can be downloaded |
As topic, The main changes in this PR are the following: