-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workspace dependencies for tee-worker(s) #3097
Conversation
* update path * further fix
* update path * further fix * need image for testing
fixes P-242 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a great effort, thanks @Kailai-Wang!
lgtm
@Kailai-Wang this will be a breaking change for a client:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good overall 👍🏼
I can feel the pain of making this changes 😆
Thanks @kziemianek ! |
It should be supported see. |
Context
Warning
It's a breaking change for bitacross client due to the
DirectRequestStatus
type changeAs topic.
This PR tries to unify the cargo dependencies of identity-worker and bitacross-worker to form a workspace-based configuration.
Please note:
tee-worker/common/
enclave-runtime
needs to have its own workspace for sgx-specific patchesidentity/core
andidentity/core-primitives
for those crates. It's still possible to merge them into a "common" crate, but bigger code change would be neededita-stf
), to overcome this, I prepended the crate name with the worker type, e.g.id-ita-stf
vsbc-ita-stf
.enum DirectRequestStatus
is defined with different entry orders in id- and bc-worker. I follow the one in id-worker to not break anything from IDHub. Do we need to change anything for bc-worker? cc @kziemianekHandleParentchainEvents
,FilterEvents
which contains fn for both workersfixes P-242
fixes P-552