Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the repo files #3079

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic, this is now the tree structure:

.
├── LICENSE
├── Makefile
├── README.md
├── common
├── local-setup
├── parachain
└── tee-worker

And in tee-worker:

└── tee-worker
    ├── bitacross
    └── identity

A root-dir can only have one workspace definition.
It would be very chaotic and incredibly long deps if I have one big Cargo.toml that specifies deps for both parachain and workers.

So I'm going to have a workspace definition for parachain and worker, respectively. The common will then come up as standalone crates.

Note

Workers still have isolated directories - I don't want to introduce too many changes in one PR. A bigger PR will follow up with workspace-dependencies for workers.

Warning

Please note the changes (in case anything needs to be changed in the deployment script) @m1iktea

@Kailai-Wang Kailai-Wang requested review from kziemianek, m1iktea and a team September 22, 2024 00:02
@Kailai-Wang Kailai-Wang self-assigned this Sep 22, 2024
Copy link

linear bot commented Sep 22, 2024

Copy link
Contributor

@jonalvarezz jonalvarezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kai,

Since it is mostly restructuring, I tested it by checking out the code locally, building the node and the identity worker and launching in standalone mode. It looks good. I could do all basic operations like retrieve/ link identity and request vc.

Copy link
Contributor

@silva-fj silva-fj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement 👍🏼

@Kailai-Wang Kailai-Wang enabled auto-merge (squash) September 23, 2024 15:28
@Kailai-Wang Kailai-Wang merged commit d67e7cb into dev Sep 23, 2024
28 checks passed
@Kailai-Wang Kailai-Wang deleted the p-239-restructure-the-parachain-repo branch September 23, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants