Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P 990 benchmark fix #3014

Merged
merged 54 commits into from
Aug 29, 2024
Merged

P 990 benchmark fix #3014

merged 54 commits into from
Aug 29, 2024

Conversation

wangminqi
Copy link
Member

@wangminqi wangminqi commented Aug 26, 2024

(1) Fix bridge related benchmark impl
(2) add several skipped benchmark back
(3) add cumulus fix in 0.9.43 update for frame-system benchmark fix
paritytech/cumulus#2766

Copy link

linear bot commented Aug 26, 2024

P-990 Benchmark fix

@wangminqi wangminqi requested review from Kailai-Wang, a team and BillyWooo August 28, 2024 07:51
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Cargo.toml Outdated Show resolved Hide resolved
@wangminqi
Copy link
Member Author

By the way, although CI passed PR approved, the merge eligibility is up to its benchmark passing.
Please do not merge before that.

Kailai-Wang and others added 11 commits August 29, 2024 10:15
* rename folders

* fix bridge-transfer benchmarking

* fix clippy

* [benchmarking bot] Auto commit generated weights files (#3029)

Co-authored-by: Kailai-Wang <[email protected]>

* enable weights

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kailai-Wang <[email protected]>
@wangminqi wangminqi merged commit 2eea020 into dev Aug 29, 2024
34 checks passed
@wangminqi wangminqi deleted the p-990-benchmark-fix branch August 29, 2024 05:45
@wangminqi
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants