Allow empty web3networks when linking identities #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonalvarezz
approved these changes
Dec 22, 2023
| Identity::Substrate(..) => all_substrate_web3networks(), | ||
| Identity::Evm(..) => all_evm_web3networks(), | ||
| Identity::Bitcoin(..) => all_bitcoin_web3networks(), | ||
| _ => Vec::new(), |
There was a problem hiding this comment.
shouldn't it throw here and panic?
There was a problem hiding this comment.
Normally we don't panic inside pallet, it's better to return an error here - but since it's on staging, I didn't even bother adding another error type (which requires refreshment of sidechain metadata) as I know it's unreachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a workaround to reduce the encoded call size.
We allow the client to pass in empty
web3networkswhen linking identities and restore it to full network types internally.Please note
set_user_shielding_keyis not affected - the client still has to provide valid network types.