🥳[Feature] Add Two Factor Authentication for Litecoin Card #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved to v0.8.0
- There is a bug in Xcode where running code coverage breaks the SwiftUI canvas
- Pre-polish the languiage and the translations - Tech Debt: Code clean up - Deleted and cleaned up files.
- UIKit updated relative to the modal
- New 2FA View - New 2FA Model
Localizations: * 2FA Not Enabled * 2FA Enabled * Enter the code that was recently sent to your Litecoin Card account email. * Enter Code * Confirm
- Stubbed in the View Extenstion tests - Enable2FAViewModel tests
kcw-grunt
added
🥳 feature
kcw-grunt
changed the title
JCHeist
suggested changes
Aug 20, 2021
loafwalletTests/Two Factor Auth Tests/Enter2FACodeViewModelTests.swift
Outdated
Show resolved
Hide resolved
|
@JasperHeist thanks...let me made changes and push them up soon (in 24 - 36 hrs) |
- Turkish is now found
* Removed the launch options - This method had `launchOptions` that was never used. * Removed all unused code.
|
@JasperHeist rebased the other develop merged PRs in:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Litecoin Card API needs a higher degree of authentication than just login for Transfers. So, the Enable2FA Api needed to be added.
Approach
There are a few structural changes tp make this happen
Screenshots/GIFs