🦺[Tech Debt] Fixed podfile: Firebase cocoapod #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kcw-grunt
commented
Jul 11, 2021
kcw-grunt
commented
- Cleaned up podfile
- Turning off the code coverage allows the SwiftUI canvas to work
kcw-grunt
commented
Jul 11, 2021
| pod 'Firebase/Analytics', '~> 6.0' | ||
| pod 'Firebase/Crashlytics', '~> 6.0' | ||
| # add pod 'SwiftLint' | ||
| pod 'Firebase/Analytics' |
There was a problem hiding this comment.
Bad edit from months ago. This updates the Firebase pod
kcw-grunt
commented
Jul 11, 2021
| @@ -28,7 +28,6 @@ | |||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | |||
| shouldUseLaunchSchemeArgsEnv = "YES" | |||
| enableASanStackUseAfterReturn = "YES" | |||
| codeCoverageEnabled = "YES" | |||
There was a problem hiding this comment.
This is a Xcode bug. You can't run code coverage and run SwiftUI canvas
|
Looks good other than the test faking for some reason. Why is that? |
Bitrise has a step that can run pod install or use the cache., based on the Podfile.lock. I need to take a look.. |
JCHeist
approved these changes
Aug 27, 2021
kcw-grunt
force-pushed
the
techdebt/fix-podfile-firebase-76
branch
from
52715a7 to
6872169
Compare
- Cleaned up podfile - Turning off the code coverage allows the SwiftUI canvas to work
kcw-grunt
force-pushed
the
techdebt/fix-podfile-firebase-76
branch
from
6872169 to
6606766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.