Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥🛠[Hotfix] Buy tab crashes #64

Merged
merged 3 commits into from
Jun 12, 2021
Merged

🔥🛠[Hotfix] Buy tab crashes #64

merged 3 commits into from
Jun 12, 2021

Conversation

kcw-grunt
Copy link
Contributor

@kcw-grunt kcw-grunt commented Jun 11, 2021

Hotfix

v3.5.0 has a critical bug where the app crashes when tapping on the Receive or Buy tabs

Approach

Fix was trivial adding new release tag Hotfix-v3.5.1

This is why we don't pay for likes!

The 2☆ review was in Russian
Screen Shot 2021-06-11 at 9 41 08 PM

Translation
Screen Shot 2021-06-11 at 9 41 17 PM

The real feedback was invaluable and helped locate the issue.

- Added TabBarViewController Tests
- Added NonUSTabBarViewController Tests
- Fixed Default Currency Test
@kcw-grunt kcw-grunt requested review from mosadialiou and JCHeist June 11, 2021 07:57
Copy link
Contributor

@mosadialiou mosadialiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosadialiou
Copy link
Contributor

@kcw-grunt Create a PR to merge hotfix/buy-tab-crashes into develop too

@kcw-grunt
Copy link
Contributor Author

@JasperHeist @mosadialiou thanks so much guys.

@kcw-grunt kcw-grunt marked this pull request as ready for review June 11, 2021 10:50
@kcw-grunt kcw-grunt merged commit 5da45ce into main Jun 12, 2021
@kcw-grunt kcw-grunt deleted the hotfix/buy-tab-crashes branch September 2, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants