🦺[Tech debt] Add configuration to hide / unhide card tab #47
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // | ||
| // LocaleChangeView.swift | ||
| // loafwallet | ||
| // | ||
| // Created by Kerry Washington on 5/11/21. | ||
| // Copyright © 2021 Litecoin Foundation. All rights reserved. | ||
| // | ||
|
|
||
| import SwiftUI | ||
|
|
||
| struct LocaleChangeView: View { | ||
|
|
||
| //MARK: - Combine Variables | ||
| @ObservedObject | ||
| var viewModel: LocaleChangeViewModel | ||
|
|
||
| init(viewModel: LocaleChangeViewModel) { | ||
| self.viewModel = viewModel | ||
| } | ||
| var body: some View { | ||
| VStack { | ||
|
|
||
| Text("Current Locale: \(viewModel.displayName)") | ||
| .font(Font(UIFont.barlowSemiBold(size: 18.0))) | ||
| .foregroundColor(.black) | ||
| .padding(.leading, 20) | ||
| .padding(.top, 10) | ||
|
|
||
| Spacer() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| struct LocaleChangeView_Previews: PreviewProvider { | ||
|
|
||
| static let viewModel = LocaleChangeViewModel() | ||
|
|
||
| static var previews: some View { | ||
|
|
||
| Group { | ||
| LocaleChangeView(viewModel: viewModel) | ||
| .previewDevice(PreviewDevice(rawValue: DeviceType.Name.iPhoneSE2)) | ||
| .previewDisplayName(DeviceType.Name.iPhoneSE2) | ||
|
|
||
| LocaleChangeView(viewModel: viewModel) | ||
| .previewDevice(PreviewDevice(rawValue: DeviceType.Name.iPhone8)) | ||
| .previewDisplayName(DeviceType.Name.iPhone8) | ||
|
|
||
| LocaleChangeView(viewModel: viewModel) | ||
| .previewDevice(PreviewDevice(rawValue: DeviceType.Name.iPhone12ProMax)) | ||
| .previewDisplayName(DeviceType.Name.iPhone12ProMax) | ||
| } | ||
| } | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // | ||
| // LocaleChangeViewModel.swift | ||
| // loafwallet | ||
| // | ||
| // Created by Kerry Washington on 5/11/21. | ||
| // Copyright © 2021 Litecoin Foundation. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| class LocaleChangeViewModel: ObservableObject { | ||
|
|
||
| var updatedLocale: Locale = Locale.current | ||
|
|
||
| //MARK: - Combine Variables | ||
| @Published | ||
| var displayName: String = "" | ||
|
|
||
| init() { | ||
| let currentLocale = Locale.current | ||
|
|
||
| if let regionCode = currentLocale.regionCode, | ||
| let name = currentLocale.localizedString(forRegionCode: regionCode) { | ||
| displayName = name | ||
| } else { | ||
| displayName = "-" | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,40 +91,61 @@ class MainViewController : UIViewController, Subscriber, LoginViewControllerDele | |
| } | ||
|
|
||
| func didUnlockLogin() { | ||
|
There was a problem hiding this comment. @kcw-grunt refactor this method like this: There was a problem hiding this comment. Oh that won't work. The classes are custom and inherit so the values can't be passed to the NonUS and Tab ViewControllers There was a problem hiding this comment. @kcw-grunt hmm I see. Can you do this 👇 ? |
||
|
|
||
| if UserDefaults.userIsInUSA { | ||
| guard let usaVC = UIStoryboard.init(name: "Main", bundle: nil) | ||
| .instantiateViewController(withIdentifier: "TabBarViewController") | ||
| as? TabBarViewController else { | ||
|
|
||
| NSLog("TabBarViewController not intialized") | ||
| return | ||
| } | ||
|
|
||
| usaVC.store = self.store | ||
| usaVC.walletManager = walletManager | ||
|
|
||
| addChildViewController(usaVC, layout:{ | ||
| usaVC.view.constrain(toSuperviewEdges: nil) | ||
| usaVC.view.alpha = 0 | ||
| usaVC.view.layoutIfNeeded() | ||
| }) | ||
|
|
||
| UIView.animate(withDuration: 0.3, | ||
| delay: 0.1, | ||
| options: .transitionCrossDissolve, | ||
| animations: { | ||
|
|
||
| usaVC.view.alpha = 1 | ||
|
|
||
| }) { (finished) in | ||
| NSLog(" Ex US MainView Controller presented") | ||
| } | ||
| } else { | ||
|
|
||
| guard let exUSAVC = UIStoryboard.init(name: "Main", bundle: nil) | ||
| .instantiateViewController(withIdentifier: "NonUSTabBarViewController") | ||
| as? NonUSTabBarViewController else { | ||
|
|
||
| NSLog("NonUSTabBarViewController not intialized") | ||
| return | ||
| } | ||
|
|
||
| exUSAVC.store = self.store | ||
| exUSAVC.walletManager = walletManager | ||
|
|
||
| addChildViewController(exUSAVC, layout:{ | ||
| exUSAVC.view.constrain(toSuperviewEdges: nil) | ||
| exUSAVC.view.alpha = 0 | ||
| exUSAVC.view.layoutIfNeeded() | ||
| }) | ||
|
|
||
| UIView.animate(withDuration: 0.3, delay: 0.1, options: .transitionCrossDissolve, animations: { | ||
| exUSAVC.view.alpha = 1 | ||
| }) { (finished) in | ||
| NSLog("US MainView Controller presented") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private func addTemporaryStartupViews() { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcw-grunt we can simplify the expression like this:
UserDefaults.userIsInUSA = suffix == "_US"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mosadialiou this is to allow people that are in the US but speak other languages . So, someone that speaks French and has their phone set for french but are in say, New York . This region code would be "fr_US".
So this code truncates the
fr.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcw-grunt yeah I understand. I am talking about the code. You can simplify it like I said!