Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when using non-main thread to call SwiftUI #263

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

azisramdhan
Copy link
Contributor

@azisramdhan azisramdhan commented Dec 14, 2024

Description

This PR contains bug fixes for:

Litewallet internal issues

It's because somehow SwiftUI is being called on a non-main thread.

Copy link
Contributor

@kcw-grunt kcw-grunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @azisramdhan .
Will you help by adding the issue number into the PR description? That way we can remember. GH makes it easy. You just hit # you can scroll through the issues.

@azisramdhan
Copy link
Contributor Author

Sure @kcw-grunt I have added into the description.

@azisramdhan azisramdhan added the 🐛 bug Something isn't working as expected label Dec 14, 2024
@azisramdhan azisramdhan self-assigned this Dec 14, 2024
@azisramdhan
Copy link
Contributor Author

Hi @kcw-grunt I can't add the issue number because it's opened on litewallet-engineering I guess

Copy link
Contributor

@kcw-grunt kcw-grunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azisramdhan
Copy link
Contributor Author

Thanks!

@azisramdhan azisramdhan merged commit 74fd48f into develop Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants