-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #3554
Closed
Closed
Version Packages #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultslit-element-list
render
update
update-reflect
lit-html-kitchen-sink
render
update
nop-update
lit-html-repeat
render
update
lit-html-template-heavy
render
update
reactive-element-list
render
update
update-reflect
|
aomarks
approved these changes
Jan 9, 2023
augustjk
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!
Test failures fixed by #3555 |
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
January 9, 2023 19:43
dc98b69
to
7bde606
Compare
The tests aren't running for some reason..I guess I'll delete this and try again. |
auto-merge was automatically disabled
January 9, 2023 19:58
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@lit-labs/[email protected]
Major Changes
72fcf0d7
- The Lit SSR global DOM shim is no longer automatically loaded when rendering Lit components from Eleventy. When paired with the latest version of Lit, the global DOM shim is no longer typically required, because Lit now automatically imports shimmed versions of needed APIs.Patch Changes
72fcf0d7
,72fcf0d7
,ff637f52
,72fcf0d7
,72fcf0d7
,c77220e8
]:@lit-labs/[email protected]
Major Changes
#3522
72fcf0d7
- ModuleLoader now provides a default VM global context object which provides basic globals that are available in both Node and browsers.#3522
72fcf0d7
- The SSR dom shim will now throw if a custom element is redefined.#3431
ff637f52
- The Lit SSR DOM shim no longer defines a globalwindow
variable. This was removed to improve compatibility with libraries that detect whether they are running in Node vs the browser by checking for the presence ofwindow
.If you have code that runs during SSR which depends on the presence of
window
, you can either replacewindow
withglobalThis
, or useisSsr
to avoid running that code on the server (see https://lit.dev/docs/ssr/authoring/#browser-only-code).#3467
c77220e8
- Allow SSR renderers to produce asynchronous values. This is a BREAKING change.This changes the return type of
render()
and theElementRenderer
render methods to be aRenderResult
, which is an iterable of strings or Promises and nested RenderResults.The iterable remains a sync iterable, not an async iterable. This is to support environments that require synchronous renders and because sync iterables are faster than async iterables. Since many server renders will not require async rendering, they should work in sync contexts and shouldn't pay the overhead of an async iterable.
Including Promises in the sync iterable creates a kind of hybrid sync/async iteration protocol. Consumers of RenderResults must check each value to see if it is a Promise or iterable and wait or recurse as needed.
This change introduces three new utilities to do this:
collectResult(result: RenderResult): Promise<string>
- an async function that joins a RenderResult into a string. It waits for Promises and recurses into nested iterables.collectResultSync(result: RenderResult)
- a sync function that joins a RenderResult into a string. It recurses into nested iterables, but throws when it encounters a Promise.RenderResultReadable
- a NodeReadable
stream implementation that provides values from aRenderResult
. This can be piped into aWritable
stream, or passed to web server frameworks like Koa.Minor Changes
#3522
72fcf0d7
- When running in Node, Lit now automatically includes minimal DOM shims which aresufficient for most SSR (Server Side Rendering) use-cases, removing the need to
import the global DOM shim from
@lit-labs/ssr
.The new
@lit-labs/ssr-dom-shim
package has been introduced, which exports anHTMLElement
,CustomElementRegistry
, and defaultcustomElements
singleton.The existing
@lit-labs/ssr
global DOM shim can still be used, and is compatible with the new package, because@lit-labs/ssr
imports from@lit-labs/ssr-dom-shim
. Importing the global DOM shim adds more APIs to the global object, such as a globalHTMLElement
,TreeWalker
,fetch
, and other APIs. It is recommended that users try to remove usage of the@lit-labs/ssr
DOM shim, and instead rely on the more minimal, automatic shimming that@lit/reactive-element
now provides automatically.#3522
72fcf0d7
- APIs such as attachShadow, setAttribute have been moved from the HTMLElement class shim to the Element class shim, matching the structure of the real API. This should have no effect in most cases, as HTMLElement inherits from Element.Patch Changes
72fcf0d7
]:@lit-labs/[email protected]
Major Changes
#3522
72fcf0d7
- When running in Node, Lit now automatically includes minimal DOM shims which aresufficient for most SSR (Server Side Rendering) use-cases, removing the need to
import the global DOM shim from
@lit-labs/ssr
.The new
@lit-labs/ssr-dom-shim
package has been introduced, which exports anHTMLElement
,CustomElementRegistry
, and defaultcustomElements
singleton.The existing
@lit-labs/ssr
global DOM shim can still be used, and is compatible with the new package, because@lit-labs/ssr
imports from@lit-labs/ssr-dom-shim
. Importing the global DOM shim adds more APIs to the global object, such as a globalHTMLElement
,TreeWalker
,fetch
, and other APIs. It is recommended that users try to remove usage of the@lit-labs/ssr
DOM shim, and instead rely on the more minimal, automatic shimming that@lit/reactive-element
now provides automatically.@lit-labs/[email protected]
Minor Changes
#3522
72fcf0d7
- @lit-labs/testing no longer automatically loads the Lit SSR global DOM shimwhen performing SSR, instead relying on newer versions of Lit which automatically
load necessary shims with minimal global pollution.
This may cause new or different test failures, because APIs such as
document
will no longer be available on the server by default. Use
isServer
from thelit
package to guard against calling such APIs during SSR (seehttps://lit.dev/docs/ssr/authoring/#browser-only-code for more information).
Patch Changes
72fcf0d7
,72fcf0d7
,ff637f52
,72fcf0d7
,72fcf0d7
,c77220e8
]:[email protected]
Minor Changes
#3522
72fcf0d7
- When running in Node, Lit now automatically includes minimal DOM shims which aresufficient for most SSR (Server Side Rendering) use-cases, removing the need to
import the global DOM shim from
@lit-labs/ssr
.The new
@lit-labs/ssr-dom-shim
package has been introduced, which exports anHTMLElement
,CustomElementRegistry
, and defaultcustomElements
singleton.The existing
@lit-labs/ssr
global DOM shim can still be used, and is compatible with the new package, because@lit-labs/ssr
imports from@lit-labs/ssr-dom-shim
. Importing the global DOM shim adds more APIs to the global object, such as a globalHTMLElement
,TreeWalker
,fetch
, and other APIs. It is recommended that users try to remove usage of the@lit-labs/ssr
DOM shim, and instead rely on the more minimal, automatic shimming that@lit/reactive-element
now provides automatically.Patch Changes
72fcf0d7
]:[email protected]
Minor Changes
#3522
72fcf0d7
- When running in Node, Lit now automatically includes minimal DOM shims which aresufficient for most SSR (Server Side Rendering) use-cases, removing the need to
import the global DOM shim from
@lit-labs/ssr
.The new
@lit-labs/ssr-dom-shim
package has been introduced, which exports anHTMLElement
,CustomElementRegistry
, and defaultcustomElements
singleton.The existing
@lit-labs/ssr
global DOM shim can still be used, and is compatible with the new package, because@lit-labs/ssr
imports from@lit-labs/ssr-dom-shim
. Importing the global DOM shim adds more APIs to the global object, such as a globalHTMLElement
,TreeWalker
,fetch
, and other APIs. It is recommended that users try to remove usage of the@lit-labs/ssr
DOM shim, and instead rely on the more minimal, automatic shimming that@lit/reactive-element
now provides automatically.@lit/[email protected]
Minor Changes
#3522
72fcf0d7
- When running in Node, Lit now automatically includes minimal DOM shims which aresufficient for most SSR (Server Side Rendering) use-cases, removing the need to
import the global DOM shim from
@lit-labs/ssr
.The new
@lit-labs/ssr-dom-shim
package has been introduced, which exports anHTMLElement
,CustomElementRegistry
, and defaultcustomElements
singleton.The existing
@lit-labs/ssr
global DOM shim can still be used, and is compatible with the new package, because@lit-labs/ssr
imports from@lit-labs/ssr-dom-shim
. Importing the global DOM shim adds more APIs to the global object, such as a globalHTMLElement
,TreeWalker
,fetch
, and other APIs. It is recommended that users try to remove usage of the@lit-labs/ssr
DOM shim, and instead rely on the more minimal, automatic shimming that@lit/reactive-element
now provides automatically.Patch Changes
72fcf0d7
]:@lit/[email protected]
Patch Changes
78811714
- - Existing XLIFF files will be updated instead of re-generated, so additional data added by other processes (such asstate="translated"
attributes) will be preserved instead of deleted.<note>
elements generated by Lit Localize will now have afrom="lit-localize"
attribute to distinguish them from other notes.72fcf0d7
]: