Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyDeclaration added index signature incompatible with previous type #928

Closed
sorvell opened this issue Mar 17, 2020 · 0 comments · Fixed by #929
Closed

PropertyDeclaration added index signature incompatible with previous type #928

sorvell opened this issue Mar 17, 2020 · 0 comments · Fixed by #929
Assignees
@sorvell

Comments

@sorvell
Copy link
Member

sorvell commented Mar 17, 2020

Initiative / goal

The index signature added in #914 can be incompatible with custom type, if that type does not have a index signature. This is a potentially breaking change and should be reverted.

Scope

  • remove the index signature on PropertyDeclaration
  • update tests to ensure it's possible to customize property options either by creating an extension type (or by casting to PropertyDeclaration )

Acceptance criteria and must have scope

Tests must compile and pass.
@sorvell sorvell self-assigned this Mar 17, 2020
sorvell pushed a commit that referenced this issue Mar 17, 2020
Removes index signature from PropertyDeclaration
93b41bf 
Fixes #928. Also add tests that type custom property options in a variety of ways.
@sorvell sorvell mentioned this issue Mar 17, 2020
Merged
kevinpschaaf pushed a commit that referenced this issue Mar 17, 2020
Removes index signature from PropertyDeclaration (#929)
38a8b85 
Fixes #928. Also add tests that type custom property options in a variety of ways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes index signature from PropertyDeclaration lit/lit-element
1 participant
@sorvell