fix max_pool2d padding issue when lowering it to tosa #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsan-toosi
requested changes
May 11, 2023
| auto outH = outputTensorTy.getShape()[1]; | ||
| auto outW = outputTensorTy.getShape()[2]; | ||
| padArr[1] = (outH - 1) * strideInts[0] - inH - padArr[0] + kernelSizeInts[0]; | ||
| padArr[1] = (padArr[1] < padArr[0]) ? padArr[0] : padArr[1]; |
There was a problem hiding this comment.
If you meant a swap to keep the bigger pad on the end, this is wrong. You can do swap(pad[0], pad[1]). Because with the current implementation if you come up with 1,0,1,0, then the pad array would be 1,1,1,1.
There was a problem hiding this comment.
no, the code is not for swapping. It's to compute the round up integer number since torch has the same padding value for left and right, top and bottom.
| padArr[1] = padArr[1] + paddingInts[0]; | ||
| padArr[3] = padArr[3] + paddingInts[1]; | ||
| RankedTensorType outputTensorTy = outputTy.cast<RankedTensorType>(); | ||
| auto inH = inputTy.getShape()[2]; |
There was a problem hiding this comment.
Suggested change
| auto inH = inputTy.getShape()[2]; | |
| auto inH = inputTy.getDimSize(2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.