Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap option for document popup #309

Closed
nbardiuk opened this issue Jan 21, 2021 · 5 comments
Closed

Wrap option for document popup #309

nbardiuk opened this issue Jan 21, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@nbardiuk
Copy link
Contributor

Documentation for java symbols is long string without line breaks which get cut at the right endge of the popup.

1611265110

As I understand cider/orchard parses javadoc from html content. Unfortunately html does not preserve original line breaks and they get lost.

Could it be possible to add an option to enable wrap for document popup?
Or maybe a maxwidth option like textwidth that would reformat content of popup with hard wrap.

@liquidz
Copy link
Owner

liquidz commented Jan 21, 2021

@nbardiuk Thanks for your reporting!

It seems maxwidth is not calculated correctly. I'll fix it.
https://github.com/liquidz/vim-iced/blob/2.7.4/autoload/iced/component/popup/vim.vim#L91

@liquidz liquidz added the bug Something isn't working label Jan 21, 2021
@nbardiuk
Copy link
Contributor Author

Great! Forgot to mention that I am using neovim 0.4.4

@liquidz
Copy link
Owner

liquidz commented Jan 22, 2021

@nbardiuk I tried to fix in dev branch.

@nbardiuk
Copy link
Contributor Author

@liquidz I've tried the dev branch. It fixed the issue for me. Thank you 👍🏻

@liquidz
Copy link
Owner

liquidz commented Jan 23, 2021

Thanks for your confirmation!
I just cut a new release.

@liquidz liquidz closed this as completed Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants