This repository was archived by the owner on Jun 15, 2022. It is now read-only.
Replace autoloader implementation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current autoloader implementation uses `set_include_path()`, which should be avoided. Since PHP 5.3, there's no valid reason to use `set_include_path()` in application code anymore, as: - it adds processing overhead and additional filesystem checks to _all_ `include`/`require` statements that follow it; - following from that, it slows down _all_ other autoloaders as well; - it can break in environments where the include path is set at the server level and cannot be changed due to security restrictions; - `spl_autoload_register()` can be fed a callback that does the `include` directly, avoiding any further processing. This alternative autoloader implementation uses a direct `include` in the callback that avoids the above drawbacks and is closer to the generally accepted approach that is now used by the PHP community (usually in the form of an autoloader generated by Composer).
stevegrunwell
approved these changes
Sep 26, 2018
|
@schlessera This is a great catch, thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current autoloader implementation uses
set_include_path(), which should be avoided.Since PHP 5.3, there's no valid reason to use
set_include_path()in application code anymore, as:include/requirestatements that follow it;spl_autoload_register()can be fed a callback that does theincludedirectly, avoiding any further processing.This alternative autoloader implementation uses a direct
includein the callback that avoids the above drawbacks and is closer to the generally accepted approach that is now used by the PHP community (usually in the form of an autoloader generated by Composer).