Skip to content
This repository has been archived by the owner on Jun 15, 2022. It is now read-only.

Cleanup CLI script and tests #78

Merged
merged 11 commits into from
Sep 13, 2018
Merged

Cleanup CLI script and tests #78

merged 11 commits into from
Sep 13, 2018

Conversation

stevegrunwell
Copy link
Contributor

This PR focus on cleaning up some of the less-obvious behaviors within the WP-CLI command and its corresponding tests:

  1. Use @ticket instead of @link DocBlock annotations
  2. Don't let the WP-CLI command suppress MySQL errors
  3. Add a new debug message (e.g. requires --debug during execution) for the beginning of each batch
  4. Explicitly reset the WP_CLI mock's static properties after each test
  5. Rather than referencing the static properties of WP_CLI directly, add custom assertions to our dummy WP_CLI_Command, enabling things like $this->cli->assertReceivedMessage($msg[, $level])

@stevegrunwell stevegrunwell added enhancement cli migration Issues related to the WP-CLI migration script labels Sep 12, 2018
@stevegrunwell stevegrunwell added this to the Version 1.0.0 milestone Sep 12, 2018
@bswatson bswatson merged commit 425363f into develop Sep 13, 2018
@bswatson bswatson deleted the fix/cli-migration-cleanup branch September 13, 2018 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli migration Issues related to the WP-CLI migration script enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants