Skip to content
This repository has been archived by the owner on Jun 15, 2022. It is now read-only.

Rename CLITest::init() to CLITest::init_cli() to avoid conflicting with WP_HTTP_TestCase::init() #72

Merged
merged 4 commits into from
Sep 11, 2018

Conversation

stevegrunwell
Copy link
Contributor

Newer releases of WooCommerce include a static WP_HTTP_TestCase method, which conflicts with our CLITest::init() (which is a @before method).

This PR renames the latter to CLITest::init_cli().

@stevegrunwell stevegrunwell added bug cli migration Issues related to the WP-CLI migration script labels Sep 11, 2018
@stevegrunwell stevegrunwell added this to the Version 1.0.0 milestone Sep 11, 2018
Previous versions of WooCommerce had this in api/system-status.php, but this file was moved into the v2 subdirectory in woocommerce/woocommerce:246672818
Based on woocommerce/woocommerce:0e785d46, the HTTP request required by `WC_Tests_Product_CSV_Importer::test_import()` was failing for earlier versions of PHP (< 7.2), and thus causing a false positive when testing WooCommerce < 3.4.
@bswatson bswatson merged commit 35b834a into develop Sep 11, 2018
@bswatson bswatson deleted the fix/cli-test-init branch September 11, 2018 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug cli migration Issues related to the WP-CLI migration script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants