Skip to content
This repository has been archived by the owner on Jun 15, 2022. It is now read-only.

Delete install table class and move install table back into main plugin file #7

Closed
wants to merge 5 commits into from
Closed

Delete install table class and move install table back into main plugin file #7

wants to merge 5 commits into from

Conversation

lukecav
Copy link
Member

@lukecav lukecav commented Dec 12, 2017

Deleted the install table class class-wc-custom-order-table-install.php and moved the class code back into the main wc-custom-order-table.php file.

@lukecav
Delete class-wc-custom-order-table-install.php
0fe8095 
Remove table install class, first steps to move the table install back into the main plugin file.
@lukecav
Update wc-custom-order-table.php
abd4f07 
Revert register_activation_hook within a register_activation_hook and move the install table class back into the main plugin file.
@lukecav lukecav requested review from boogah and bswatson December 13, 2017 03:37
boogah
boogah suggested changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@boogah boogah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing in the ported over install_tables() code is inconsistent (mix of spaces and tabs) and the closing bracket on line 99 appears to be superfluous due to the copy/paste performed here.

@lukecav
Make spaces and tabs consistent
a8e2c2a 
Fix spaces and tabs on the code taken from `class-wc-custom-order-table-install.php`.
@lukecav
Copy link
Member Author

lukecav commented Dec 13, 2017

Fixed the issues with the spaces and the tabs, my mistake for not catching that.

@lukecav
Copy link
Member Author

lukecav commented Dec 14, 2017

Will revert changes and use a constructor similar to how WooCommerce does and then have the installer class to be called statically.

@lukecav
Restore class for order table install
4b28e89 
Revert first of the previous changes made.
@lukecav
Revert changes made to the main plugin file
a6507ea 
Remove order table install code from the main plugin file and restore register_activation_hook.
@lukecav
Copy link
Member Author

lukecav commented Dec 14, 2017 •
edited
Loading

Reverted the previous changes to a clean slate for making the necessary changes needed.

stevegrunwell added a commit that referenced this pull request Dec 22, 2017
@stevegrunwell
Remove the double plugin activation hook and write a regression test …
77022c5 
…for it.

Previously, wc_custom_order_table_install() — which is called via register_activation_hook() — was then calling register_activation_hook() a second time, preventing the WC_Custom_Order_Table_Install::activate() method from ever firing on plugin activation.

Fixes #5, closes #7.
@stevegrunwell stevegrunwell mentioned this pull request Dec 22, 2017
Merged
@lukecav lukecav closed this Dec 22, 2017
@lukecav
Copy link
Member Author

lukecav commented Dec 23, 2017 •
edited
Loading

Closed due to #9.

stevegrunwell pushed a commit that referenced this pull request May 23, 2018
@coenjacobs
Merge pull request #7 from liquidweb/fix-data-store-ref
5b3fa54 
Access data store through get method on WC data class
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boogah boogah boogah requested changes

@bswatson bswatson Awaiting requested review from bswatson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukecav @boogah