This repository was archived by the owner on Jun 15, 2022. It is now read-only.
Address duplicate order keys #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two tests, `DataStoreTest::test_populate_from_meta_handles_errors()` and `CLITest::test_migrate_skips_on_database_error()`, were explicitly setting order keys to empty strings, which is being fixed in #97. This commit changes the tests to use generic (but still identical) order key values.
bswatson
approved these changes
Dec 14, 2018
This was referenced Dec 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #97 in addressing issues with duplicate order keys:
When saving an order to the custom table, an empty order key was being stored as
''(an empty string), rather than explicitly beingNULL. Since there's aUNIQUEkey on that column, only one order could have an empty order key, and others would fail due to the uniqueness constraint.This PR ensures that an empty order key is explicitly being cast as
NULLas data is being prepared to go into the custom table, avoiding the table constraint.Fixes #69, fixes #96.