Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander core fix hang #513

Merged

Conversation

Meriemi-git
Copy link
Contributor

@Meriemi-git Meriemi-git commented Oct 3, 2022

Reduce the _REPORT_LENGTH and _RESPONSE_LENGTH from 1024 to 96 to fix hang when loop over liquidctl status command according to @ParkerMc comment on issue #505

Fixes: #505


Checklist:

  • Adhere to the development process
  • Conform to the style guide
  • Verify that the changes work as expected on real hardware
  • Add automated tests cases
  • Verify that all (other) automated tests (still) pass
  • Update the README and other applicable documentation pages
  • Update the liquidctl.8 Linux/Unix/Mac OS man page
  • Update or add applicable docs/*guide.md device guides
  • Submit relevant data, scripts or dissectors to https://github.com/liquidctl/collected-device-data

New CLI flag?

  • Adjust the completion scripts in extra/completions/

New device?

  • Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
  • Add entry to the README's supported device list with applicable notes (at least en)

New driver?

  • Document the protocol in docs/developer/protocol/

@ParkerMc
Copy link
Contributor

ParkerMc commented Oct 3, 2022

In the documentation, instead of just changing it from 1024 bytes to 96 bytes. Can you mention that it is 1024 for firmware v1.x.x and 96 for v2.x.x.
I know v1.x.x will take both 1024 and 96 but as we know now v2.x.x will only take 96 bytes.

@Meriemi-git
Copy link
Contributor Author

You're right @ParkerMc i mention both values in documentation.

@jonasmalacofilho jonasmalacofilho merged commit ad80134 into liquidctl:main Oct 4, 2022
@jonasmalacofilho
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

liquidctl status hangs every once in a while on an (up-to-date) Commander Core
3 participants