DAT-18810: app naming updated, it contains now versions of core/pro liquibase and extension version also. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iquibase and extension version also.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Updated AppName for local execution from IDE: 
|
|
Also works for commercial with dependency on current branches artifact: 
|
| boolean isCommercial = model.getArtifactId().contains("commercial"); | ||
| String buildVersion = LiquibaseUtil.getBuildVersion(); | ||
| String extVersion = model.getVersion(); | ||
| String appType = isCommercial ? "PRO" : "OSS"; |
There was a problem hiding this comment.
I think appType should depend on a license check
There was a problem hiding this comment.
license check added on commercial extension side as:
driverProperties.put("appName", getAppName(driverProperties, LicenseServiceUtils.isProLicenseValid()));
|
related pro PR (fails as waiting for master-SNAPSHOT artifact) https://github.com/liquibase/liquibase-commercial-mongodb/pull/296/files |
filipelautert
approved these changes
Jan 31, 2025
src/main/java/liquibase/ext/mongodb/database/MongoConnection.java
Outdated
Show resolved
Hide resolved
…on() used for core version
KushnirykOleh
approved these changes
Jan 31, 2025
src/main/java/liquibase/ext/mongodb/database/MongoConnection.java
Dismissed
Show dismissed
Hide dismissed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Built Jar-s with different core and pro JAR-s stored in
liquibase/lib.Only OSS Jar is present:
Commercial Jar is present and Pro license is valid:
