Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Network: InternalNode controller #2173

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Internal Network: InternalNode controller #2173

merged 1 commit into from
Dec 5, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 28, 2023

Description

This PR implements the InternalNode controller.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/ctrl-routes branch 2 times, most recently from 0024bed to 56fcb7b Compare November 29, 2023 11:19
@cheina97 cheina97 force-pushed the network-internal branch 2 times, most recently from 7bf5dbf to 9cad580 Compare November 29, 2023 15:57
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Dec 1, 2023
@fra98 fra98 marked this pull request as ready for review December 1, 2023 10:37
@fra98 fra98 force-pushed the frt/ctrl-routes branch 2 times, most recently from 1be3f88 to 74991f0 Compare December 1, 2023 10:47
@fra98 fra98 force-pushed the frt/ctrl-routes branch 2 times, most recently from f6be5da to ee80ab6 Compare December 1, 2023 13:47
@cheina97 cheina97 marked this pull request as draft December 5, 2023 09:10
@fra98 fra98 force-pushed the frt/ctrl-routes branch 3 times, most recently from 21674cb to 3145804 Compare December 5, 2023 11:34
@fra98 fra98 marked this pull request as ready for review December 5, 2023 11:34
@fra98 fra98 force-pushed the frt/ctrl-routes branch 2 times, most recently from a05cbb9 to ad65ac2 Compare December 5, 2023 12:14
@fra98 fra98 merged commit d007e49 into liqotech:network-internal Dec 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @cheina97