Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Network: network webhook and logs fixes #2172

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 28, 2023

Description

This PR deletes the clusterID label check on the Network webhook.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 marked this pull request as ready for review November 29, 2023 11:08
@fra98 fra98 requested a review from cheina97 November 29, 2023 11:20
@fra98 fra98 force-pushed the frt/ext-net-fixes branch from 4dd0812 to a4ab1d6 Compare November 29, 2023 11:28
@fra98 fra98 changed the title Network webhook and logs fixes External Network: network webhook and logs fixes Nov 29, 2023
@fra98 fra98 force-pushed the frt/ext-net-fixes branch from a4ab1d6 to 89fb80b Compare November 29, 2023 13:31
@fra98 fra98 merged commit 8db4102 into liqotech:network-external Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants