Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Network: Internal Fabric Operator #2171

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Internal Network: Internal Fabric Operator #2171

merged 1 commit into from
Dec 1, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Nov 28, 2023 •
edited
Loading

Description

This pr implements the logic to create an InternalNode resource for each InternalFabric and each Node.

How Has This Been Tested?

  • locally

@aleoli aleoli changed the base branch from master to network-internal November 28, 2023 10:49
@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli removed the size/XXL label Nov 28, 2023
@aleoli
Copy link
Member Author

aleoli commented Nov 28, 2023

/build

1 similar comment
@aleoli
Copy link
Member Author

aleoli commented Nov 28, 2023

/build

@aleoli aleoli force-pushed the aol/internal-fabric-operator branch 2 times, most recently from 3dd3c7c to a8d4105 Compare November 28, 2023 13:47
@aleoli aleoli force-pushed the aol/internal-fabric-operator branch from a8d4105 to 69afdff Compare November 28, 2023 13:50
@cheina97 cheina97 force-pushed the aol/internal-fabric-operator branch 2 times, most recently from ae879ea to 94ec73f Compare November 29, 2023 14:11
@cheina97 cheina97 marked this pull request as ready for review November 29, 2023 14:12
@cheina97 cheina97 force-pushed the network-internal branch 2 times, most recently from 7bf5dbf to 9cad580 Compare November 29, 2023 15:57
@fra98
Copy link
Member

fra98 commented Nov 29, 2023

/rebase

@cheina97 cheina97 force-pushed the aol/internal-fabric-operator branch from 94ec73f to 784852f Compare November 29, 2023 16:22
@cheina97
Copy link
Member

cheina97 commented Dec 1, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 1, 2023
@adamjensenbot adamjensenbot merged commit 93e3e31 into liqotech:network-internal Dec 1, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleoli @adamjensenbot @fra98 @cheina97