Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorconfig: skip migrations for isort #3253

Merged
merged 1 commit into from
Nov 17, 2020
Merged

editorconfig: skip migrations for isort #3253

merged 1 commit into from
Nov 17, 2020

Conversation

fuzzylogic2000
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 commented Nov 16, 2020 •
edited
Loading

@Rineee
Copy link
Contributor

Rineee commented Nov 17, 2020

Did you also already try this --filter-files option: PyCQA/isort#885 (comment) ?
If not, maybe that works? I could try it out, if you want..

@fuzzylogic2000
Copy link
Contributor Author

Awesome! I will try that later, thank you! @Rineee

@fuzzylogic2000 fuzzylogic2000 changed the title editorconfig: skip migrations for isort WIP: editorconfig: skip migrations for isort Nov 17, 2020
@fuzzylogic2000
Copy link
Contributor Author

@Rineee NIce! That did work!
I also changed --df to --diff for the sake of being the same as in make lint. They both do the same.

@fuzzylogic2000 fuzzylogic2000 changed the title WIP: editorconfig: skip migrations for isort editorconfig: skip migrations for isort Nov 17, 2020
@rmader
Copy link
Contributor

rmader commented Nov 17, 2020

Oh nice!

Rineee
Rineee approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@Rineee Rineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice!

@Rineee Rineee merged commit efee8c0 into master Nov 17, 2020
@Rineee Rineee deleted the ka-2020-11-lint-quick branch November 17, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmader rmader rmader approved these changes

@Rineee Rineee Rineee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclude migratiuons from lint-python-files
3 participants
@fuzzylogic2000 @Rineee @rmader