Disable docker push image in ci. (vmware-tanzu#556)

* Disable docker push image in ci. Signed-off-by: Liping Xue <[email protected]> * Address comments from Xing. Signed-off-by: Liping Xue <[email protected]> --------- Signed-off-by: Liping Xue <[email protected]>
lipingxue · Nov 2, 2023 · f864c8e · f864c8e
1 parent 63c38ab
commit f864c8e
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,11 +25,12 @@ jobs:
         run: |
           cd src/github.com/vmware-tanzu/velero-plugin-for-vsphere
           make ci
-      - name: Build the plugin and push images to docker hub
-        if: github.event_name == 'push' && github.repository == 'vmware-tanzu/velero-plugin-for-vsphere'
-        env:
-          GOPATH: ${GITHUB_WORKSPACE}
-        run: |
-          cd src/github.com/vmware-tanzu/velero-plugin-for-vsphere
-          echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
-          make push
+      # The following code are commented out because push image will fail due to invalid username/password for docker hub    
+      #- name: Build the plugin and push images to docker hub
+      #  if: github.event_name == 'push' && github.repository == 'vmware-tanzu/velero-plugin-for-vsphere'
+      #  env:
+      #    GOPATH: ${GITHUB_WORKSPACE}
+      #  run: |
+      #    cd src/github.com/vmware-tanzu/velero-plugin-for-vsphere
+      #    echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin
+      #    make push