add whatsnew and add comments to pandas/tests/arrays/boolean/test_red…

…uction.py related to issue pandas-dev#33253
linxiaow · Apr 5, 2020 · 1a08e61 · 1a08e61
1 parent 7106f90
commit 1a08e61
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/doc/source/whatsnew/v1.1.0.rst b/doc/source/whatsnew/v1.1.0.rst
@@ -368,7 +368,8 @@ Missing
 ^^^^^^^
 
 - Calling :meth:`fillna` on an empty Series now correctly returns a shallow copied object. The behaviour is now consistent with :class:`Index`, :class:`DataFrame` and a non-empty :class:`Series` (:issue:`32543`).
-
+- Bug in :meth:`array.any` incorrectly returns ``<NA>`` for pandas.array of all ``False`` value, e.g. ``pd.array([False, False], dtype="boolean")``. Now it returns ``False`` (:issue:`33253`)
+- Bug in :meth:`array.all` incorrectly returns ``<NA>`` for pandas.array of all ``True`` value, e.g. ``pd.array([True, True], dtype="boolean")``. Now it returns ``True``(:issue:`33253`)
 
 MultiIndex
 ^^^^^^^^^^

diff --git a/pandas/tests/arrays/boolean/test_reduction.py b/pandas/tests/arrays/boolean/test_reduction.py
@@ -12,6 +12,7 @@ def data():
     )
 
 
+# .any(), .all() returns <NA> for [False, False], [True, True], GH-33253.
 @pytest.mark.parametrize(
     "values, exp_any, exp_all, exp_any_noskip, exp_all_noskip",
     [
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,6 +12,7 @@ def data(): @@
         )
+    # .any(), .all() returns <NA> for [False, False], [True, True], GH-33253.
     @pytest.mark.parametrize(
         "values, exp_any, exp_all, exp_any_noskip, exp_all_noskip",
         [
@@ Expand Down @@