Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket proxying #7

Merged
merged 4 commits into from
Sep 8, 2020
Merged

WebSocket proxying #7

merged 4 commits into from
Sep 8, 2020

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Sep 1, 2020

http://nginx.org/en/docs/http/websocket.html

Many of our https://github.com/linuxserver/reverse-proxy-confs already include similar headers but not done in the way recommended in the nginx docs. This covers them all with the ability to proxy websockets.

I will create a separate PR to cleanup/adjust proxy samples in that repo.

Edit: linuxserver/reverse-proxy-confs#197 should be merged BEFORE this.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@nemchik
Copy link
Member Author

nemchik commented Sep 1, 2020

Updated OP that proxy PR should be merged BEFORE swag PR so the new proxies are included in the next swag build.

Fix indentation
@aptalca aptalca merged commit 4a04306 into master Sep 8, 2020
@aptalca aptalca deleted the websocket-proxying branch September 8, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants