adds an allow LAN ip list if geoip2 default is no. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here are the test results for this PR: |
aptalca
approved these changes
Oct 27, 2020
|
I am a bot, here are the test results for this PR: |
aptalca
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds an allow_list variable that you need to use if $allowed_country or $allowed_city
defaultis set to no.Setting
IP/CIDR yes;does not work.I got a false positive last time I tested, as I was testing on a CF proxied domain. So my IP was being proxied and I werent accessing the domain through a local ip.
Benefits of this PR and context:
Fixes the current geoip2 setup instructions.
Closes #19
How Has This Been Tested?
Tested on my swag setup.
Source / References: