-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torrenting port configuration support #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I don't have an issue with this in principle but please remove the readme references to running without a Will also need a matching PR for the libtorrentv1 branch. |
Hey @thespad,
Would you like me to re-word the description in readme-vars.yml too, or just the pull request description?
Thanks for the reminder, I'll create it shortly! |
readme-vars please. |
Updated both Let me know what do you think! |
I am a bot, here are the test results for this PR:
|
Description:
Adds
TORRENTING_PORT
environment variable for easy qBittorrent port change.Benefits of this PR and context:
The torrenting port is can override qBittorrent's setting without changing the configuration. This increases the portability of the container and adds more granular control over its behaviour.
How Has This Been Tested?
image
in an existing docker-compose.yml to point the newly created image:docker compose ps --format 'table {{.Service}}\t{{.Image}}\t{{.Status}}\t{{.Ports}}'
for checking the status:docker compose exec qbittorrent sh
and checked the running command:Source / References:
Relates to the stale #227 pull request.