Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-server-nodejs] Update repo, drop support for node 14 #780

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[code-server-nodejs] Update repo, drop support for node 14 #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ This mod adds a nodejs dev environment to code-server/openvscode-server, to be i

In code-server/openvscode-server docker arguments, set an environment variable `DOCKER_MODS=linuxserver/mods:code-server-nodejs`

You can define the nodejs major version to be installed via setting the environment variable `NODEJS_MOD_VERSION` (accepts `16`, `18`, etc. defaults to `14`).
You can define the nodejs major version to be installed via setting the environment variable `NODEJS_MOD_VERSION` (accepts `16`, `18`, 20, etc. Minimum of `16`, defaults to `16`).

If adding multiple mods, enter them in an array separated by `|`, such as `DOCKER_MODS=linuxserver/mods:code-server-nodejs|linuxserver/mods:code-server-mod2`
7 changes: 3 additions & 4 deletions root/etc/s6-overlay/s6-rc.d/init-mod-code-server-nodejs-add-package/run
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
#!/usr/bin/with-contenv bash

echo "**** installing nodejs dev environment ****"
source /etc/lsb-release
NODEJS_MOD_VERSION=${NODEJS_MOD_VERSION:-14}
NODEJS_MOD_VERSION=${NODEJS_MOD_VERSION:-16}
if [[ ! -f "/etc/apt/sources.list.d/nodesource.list" ]]; then
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | gpg --dearmor | tee /usr/share/keyrings/nodesource.gpg >/dev/null
echo "deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODEJS_MOD_VERSION}.x ${DISTRIB_CODENAME} main" \
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor | tee /usr/share/keyrings/nodesource.gpg >/dev/null
echo "deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODEJS_MOD_VERSION}.x nodistro main" \
> /etc/apt/sources.list.d/nodesource.list
fi
if [[ ! -f "/etc/apt/sources.list.d/yarn.list" ]]; then
Expand Down