Change worker_processes value to auto #318
Conversation
The nginx documentation says (http://nginx.org/en/docs/ngx_core_module.html#worker_processes): The optimal value depends on many factors including (but not limited to) the number of CPU cores, the number of hard disk drives that store data, and load pattern. When one is in doubt, setting it to the number of available CPU cores would be a good start (the value “auto” will try to autodetect it). So changing the "worker_processes" value to auto is more general, then the current option.
|
I'm not sure this is going to work inside a docker environment. |
|
Here is an interesting potential workaround: NUMPROCS=$(cat /sys/fs/cgroup/cpuacct/cpuacct.usage_percpu | wc -w)
sed -i "s/worker_processes\\s\\+1;/worker_processes ${NUMPROCS};/" /etc/nginx/nginx.confFound here: trajano/nginx-letsencrypt@fa4b90a#diff-c15c3b6492080efd90b52266848ca621 Edit: The snip above would probably be put into an init script in |
|
@nemchik That seems overly complicated an automation step for something that can be easily configured by changing one number. The container is a starting point for a Nginx install, it can never be all things to all people. |
The nginx documentation says (http://nginx.org/en/docs/ngx_core_module.html#worker_processes): The optimal value depends on many factors including (but not limited to) the number of CPU cores, the number of hard disk drives that store data, and load pattern. When one is in doubt, setting it to the number of available CPU cores would be a good start (the value “auto” will try to autodetect it).
So changing the "worker_processes" value to auto is more general, then the current option.