Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous for nightly #278

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

drizuid
Copy link
Member

@drizuid drizuid commented Oct 17, 2023

linuxserver.io


  • [X ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

while working on some issues in lazylibrarian with missing packages, it was determined that the missing packages are required for the calibre mod. In the case of CW, these were being installed on the container which did not appear to need them without the calibre mod. a paired PR (linuxserver/docker-mods#774) adds these packages into the mod so that it works consistently across both LL and CW.

Benefits of this PR and context:

Remove the packages which aren't needed for the base install. speeds up install and reduces size.

How Has This Been Tested?

tested locally for base functionality without mod, added mod PR to confirm functionality

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/calibre-web/nightly-87b3999e-pkg-04ce7c4a-dev-79b67d7e437954fd75b7a60bfe23976c7897cf4d-pr-278/index.html
https://ci-tests.linuxserver.io/lspipepr/calibre-web/nightly-87b3999e-pkg-04ce7c4a-dev-79b67d7e437954fd75b7a60bfe23976c7897cf4d-pr-278/shellcheck-result.xml

Tag Passed
amd64-nightly-87b3999e-pkg-04ce7c4a-dev-79b67d7e437954fd75b7a60bfe23976c7897cf4d-pr-278
arm64v8-nightly-87b3999e-pkg-04ce7c4a-dev-79b67d7e437954fd75b7a60bfe23976c7897cf4d-pr-278

@drizuid drizuid requested a review from a team October 18, 2023 01:20
@drizuid drizuid merged commit 6d36b4e into nightly Oct 18, 2023
@drizuid drizuid deleted the remove-superfluous-for-nightly branch October 18, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants